Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch all computers without a date filter. #37219

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

yedidyacohenpalo
Copy link
Contributor

@yedidyacohenpalo yedidyacohenpalo commented Nov 14, 2024

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: CIAC-12027

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

@yedidyacohenpalo yedidyacohenpalo self-assigned this Nov 14, 2024
@yedidyacohenpalo yedidyacohenpalo changed the title done fetch all computers parameter to enable fetching without a date filter. Nov 14, 2024
@yedidyacohenpalo yedidyacohenpalo changed the title fetch all computers parameter to enable fetching without a date filter. fetch all computers without a date filter. Nov 14, 2024
Copy link

github-actions bot commented Nov 14, 2024

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/JamfProtect/Integrations/JamfProtectEventCollector
   JamfProtectEventCollector.py2103284%70–75, 87–89, 102–111, 124–125, 138, 142, 161–163, 234, 333, 381, 398–399, 750
TOTAL2103284% 

Tests Skipped Failures Errors Time
104 0 💤 0 ❌ 0 🔥 12.014s ⏱️

Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! please see my comments

Copy link
Contributor

@jbabazadeh jbabazadeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants